Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musescore: 4.4.0 -> 4.4.1 #339895

Merged
merged 3 commits into from
Sep 8, 2024
Merged

musescore: 4.4.0 -> 4.4.1 #339895

merged 3 commits into from
Sep 8, 2024

Conversation

doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant
Copy link
Contributor

@ofborg eval

@azuwis
Copy link
Contributor

azuwis commented Sep 6, 2024

#337764 breaks darwin build, qtwayland should be Linux only.

Could you please also fix it in this PR?

@doronbehar
Copy link
Contributor Author

#337764 breaks darwin build, qtwayland should be Linux only.

Could you please also fix it in this PR?

Yes, thanks!

@doronbehar
Copy link
Contributor Author

Hey @azuwis if you posses a Darwin machine and would like to speed this update a bit, there are potentially more missing headers for Darwin.

@doronbehar
Copy link
Contributor Author

Currently I'm relying upon ofborg.

@azuwis
Copy link
Contributor

azuwis commented Sep 8, 2024

Result of nixpkgs-review pr 339895 run on aarch64-darwin 1

1 package built:
  • musescore

@doronbehar doronbehar merged commit 3166349 into NixOS:master Sep 8, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants